Feature/lit 3379 investigate bls signed session bug #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximusHaximus
requested changes
Jun 11, 2024
packages/lit-node-client-nodejs/src/lib/helpers/validate-bls-session-sig.ts
Show resolved
Hide resolved
packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts
Outdated
Show resolved
Hide resolved
Ansonhkg
reviewed
Jun 11, 2024
packages/lit-node-client-nodejs/src/lib/helpers/validate-bls-session-sig.ts
Show resolved
Hide resolved
packages/lit-node-client-nodejs/src/lib/helpers/validate-bls-session-sig.ts
Show resolved
Hide resolved
added 5 commits
June 11, 2024 11:45
Ansonhkg
approved these changes
Jun 12, 2024
joshLong145
deleted the
feature/lit-3379-investigate-bls-signed-session-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds BLS signature verification for
checkToResignSessionKeyas we will use thesiweverify implementation fored25519keys.Currently we will effectively retry the operation if the BLS verification fails. The retried operation has a low likelihood of success as we will be performing a retry with the same
network keywhich means that it will fail to verify as the same signing key will be used with the same message which produced the original error.It is out of scope of this pr to address the resigning issues for BLS signatures but mentioning it as it is a follow up task to address